Merged
Conversation
joyliu-q
approved these changes
Feb 19, 2025
Contributor
joyliu-q
left a comment
joyliu-q
left a comment
There was a problem hiding this comment.
LGTM! Thanks Luke. Also make sure to bump the version of shared actions the failing products r using. Really appreciate this :D
This was referenced Feb 20, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github actions deprecated their v2 actions which is causing all our stuff to fail, I bumped the actions and fixed a few typos I think. I'm kinda bad at github actions though so could someone review