Conversation
joyliu-q
requested changes
Feb 25, 2024
Contributor
There was a problem hiding this comment.
After discussion, should not remove publish step.
- Some misunderstanding on what this workflow does or is used (this is different from frontend check or backend check, but the react workflow) <-- looking for react-check.yaml
- Just because other products are using pinned versions doesn't mean its ok to just remove it from every other version in the future
Member
|
see courses for example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Bun as a frontend dependency manager option and remove the publish frontend step from the frontend check (Clubs, OHQ, and Courses appear to be using pinned versions that don't contain this step; this also makes the frontend check more consistent with the backend check, which doesn't have the publish step either).