Update matrix #56
Merged
Update matrix #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…intent/soa-workbench into ui-move-transition-rules pull
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the matrix display format and fixes several data generation issues. The changes ensure proper code system formatting, correct HTML form behavior, and enhanced matrix visualization with additional timing information.
Changes:
- Updated code system generation to prepend "db://" prefix for proper system identification
- Fixed HTML template form control to ensure NULL is inserted when no default condition is selected
- Enhanced matrix display to show timeline, encounter, epoch, timing label, study day, and visit window information in separate header rows
- Added ISO-8601 duration parsing utility to convert duration strings to days for display
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/usdm/generate_study_timings.py | Prepends "db://" to code system values for proper system identification |
| src/soa_builder/web/utils.py | Adds ISO-8601 duration to days conversion helper function |
| src/soa_builder/web/templates/rules.html | Moves closing table tag outside loop for correct HTML structure |
| src/soa_builder/web/templates/instances.html | Corrects select option to use "value" attribute instead of "name" |
| src/soa_builder/web/templates/elements.html | Moves closing table tag outside loop for correct HTML structure |
| src/soa_builder/web/templates/edit.html | Restructures matrix header to display timing metadata in separate rows and simplifies instance column headers |
| src/soa_builder/web/app.py | Enhances instance query to retrieve timing metadata and converts study day duration to numeric days |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spelling Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matrix format updated
Generator for instances updated to include correct code system
Instance HTML template updated to ensure NULL inserted in database when no default_condition_uid chosen