UI move transition rules #55
Conversation
There was a problem hiding this comment.
Pull request overview
This PR moves the transition rules UI functionality to a dedicated page and refactors element and transition rule endpoints from the main app.py file into separate router modules for better code organization.
Changes:
- Created new UI pages for elements and transition rules with dedicated templates
- Refactored element and transition rule CRUD operations into separate router modules
- Updated endpoint URLs to follow RESTful patterns (e.g.,
/ui/soa/{soa_id}/elements/createinstead of/ui/soa/{soa_id}/add_element)
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_ui_add_element.py | Updated test to use new element creation endpoint |
| tests/test_element_audit_endpoint.py | Updated tests to use new element CRUD endpoints and more flexible status code assertions |
| src/soa_builder/web/templates/rules.html | New template for transition rules listing and management UI |
| src/soa_builder/web/templates/elements.html | Refactored elements template with dropdown selectors for transition rules |
| src/soa_builder/web/templates/edit.html | Removed inline elements and transition rules sections (moved to dedicated pages) |
| src/soa_builder/web/templates/base.html | Added navigation links to new Elements and Transition Rules pages |
| src/soa_builder/web/schemas.py | Added RuleCreate and RuleUpdate schemas |
| src/soa_builder/web/routers/visits.py | Removed commented-out code and debug logging |
| src/soa_builder/web/routers/rules.py | New router module for transition rules CRUD operations |
| src/soa_builder/web/routers/elements.py | Refactored elements router with new CRUD endpoints |
| src/soa_builder/web/initialize_database.py | Made transition rule text field optional |
| src/soa_builder/web/audit.py | Moved transition rule audit function from app.py |
| src/soa_builder/web/app.py | Removed transition rule endpoints (moved to router), added router import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adjusted colspan Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
spelling Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
adjusted colspan Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
spelling Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
included status_code Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
spelling Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
spelling Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
UI page for transition rules