UI add arm page #54
Merged
UI add arm page #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a dedicated UI page for managing study arms, refactoring arms-related logic from edit.html into a new standalone page and router module.
Changes:
- Created new
arms.htmltemplate with a table-based UI for managing arms - Moved all arm CRUD operations to
routers/arms.pywith dedicated API and UI endpoints - Removed arms management section from
edit.html - Added utility functions for loading arm type and data origin type mappings
- Enhanced
generate_encounters.pyto support optional environmental settings and contact modes
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/usdm/generate_encounters.py | Added support for optional environmental settings and contact modes in encounters |
| src/soa_builder/web/utils.py | Added utility functions for arm type/data origin mappings and generic submission value lookup |
| src/soa_builder/web/templates/edit.html | Removed arms management section (moved to dedicated page) |
| src/soa_builder/web/templates/base.html | Added navigation link to new arms page |
| src/soa_builder/web/templates/arms.html | New dedicated arms management page with table-based UI |
| src/soa_builder/web/routers/epochs.py | Added missing connection cleanup and deprecated marker |
| src/soa_builder/web/routers/arms.py | Complete refactor with separate API/UI endpoints and improved code/terminology handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new UI arms page
Moved all create/update/delete logic to routers/arms.py
Cleaned up deprecated functions in app.py
Removed arms logic from edit.html