address_search_using_ids: add macrocounty as synonym for locality
#1708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
added a commit
to pelias/acceptance-tests
that referenced
this pull request
Dec 2, 2025
missinglink
added a commit
to pelias/acceptance-tests
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
macrocountryas an alias forlocalitywhen usingaddress_search_using_idsqueries (ie. search with placeholder).The major benefit of this change is that queries in Australia which include a token such "Sydney" will be expanded to include results from the Greater Sydney Area rather than only Sydney Central.
For example,
300 Burns Bay Road, Sydney, AUThis will additionally improve all other Australian cities and will affect any other countries using
macrocounty, which at time of writing includes France, UK, Taiwan & French Guiana:This will now allow the
address_search_using_idsqueries to match for the largermacrocountyarea instead of the smallerlocalitylayer, this should be fine in all other cases, most notably it might potentially expand a little far in France, let's keep an eye on this, for example the token "Lyon" which previously only matched the smaller area, now matches the wider area, although this includes the airport...Finally worth noting the original work, as mentioned in the code comments in this file are designed to prevent the inverse from happening in the USA, this functionality has been maintained: