Allow sending track_total_hits with ES query
#1704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few versions ago, Elasticsearch introduced an optimization where they only approximate the total hit count for a query (max of 10,000). It's of course nice to get better performance, but having hit count information is also super useful to examine queries for our own optimization. This change allows us to enable the [`track_total_hits`](https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-search#operation-search-track_total_hits) flag on ES queries, with the similar `api.trackTotalHits` boolean in `pelias.json`.
orangejulius
force-pushed
the
track_total_hits
branch
from
4354aae to
750d2ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few versions ago, Elasticsearch introduced an optimization where they only approximate the total hit count for a query (max of 10,000).
It's of course nice to get better performance, but having hit count information is also super useful to examine queries for our own optimization.
This change allows us to enable the
track_total_hitsflag on ES queries, with the similarapi.trackTotalHitsboolean inpelias.json.