Open
Conversation
…impleConsoleWrapper` and introduce `PinCliParameters` for argument parsing.
…esting conflicts
…package versions
…ation in `ExportPrivateKeyTest`.
… definition. Simplify `PinEntry` class by eliminating unused XML-based CLI parsing functionality.
chilimatic
commented
Feb 3, 2026
| } | ||
|
|
||
| if ($filename != '') { | ||
| if (($this->logFile = fopen($filename, 'w')) === false) { |
Author
There was a problem hiding this comment.
wb was one of the warning i have. i have a lot of inspections running and did not even react to most warnings.
i can revert this if wanted.
chilimatic
commented
Feb 3, 2026
| . 'for writing.' . PHP_EOL, | ||
| self::VERBOSITY_ERRORS | ||
| ); | ||
| exit(1); |
Author
There was a problem hiding this comment.
i just removed the else. because object calistenics / google coding standard. if you are more a dijkstra fan i can add the else again.
you need to scroll a bit down and you see it was not removed just the "else clause" and the dead code.
…eyTest` and `SimpleCliWrapper`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#41 replacing abandoned pear/console_commandline