-
Notifications
You must be signed in to change notification settings - Fork 9
Fix default CMAKE_BUILD_TYPE value #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@benoitmartin88 as discussed, here is the PR |
benoitmartin88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
jbigot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good and needed fix. Thanks
jbigot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As soon as all the "administrative" stuff is taken care of (issue, author, etc.) I'd say this is good to ship
done |
992969b to
5979d98
Compare
Fix default CMAKE_BUILD_TYPE value, fixes #617
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format;Fix #issuekeyword to autoclose the issue when merged.