-
Notifications
You must be signed in to change notification settings - Fork 9
Fix #438, add a deactivation option through CMake #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Warning you're updating the tutorial. This is unrelated |
benoitmartin88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is almost ready for merge. Just a few changes are needed.
The tutorial previously used broke the CI. |
Changing back to tutorial @ 7334107. |
a1d6fd8 to
a2da9b2
Compare
benoitmartin88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
237f3ae
Missing the case where paraconf is missing.
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format;Fix #issuekeyword to autoclose the issue when merged.