Skip to content

Conversation

@JAuriac
Copy link
Contributor

@JAuriac JAuriac commented Feb 20, 2025

Missing the case where paraconf is missing.

List of things to check before making a PR

Before merging your code, please check the following:

  • you have added a line describing your changes to the Changelog;
  • you have added unit tests for any new or improved feature;
  • In case you updated dependencies, you have checked pdi/docs/CheckList.md
  • you have checked your code format:
    • you have checked that you respect all conventions specified in CONTRIBUTING.md;
    • you have checked that the indentation and formatting conforms to the .clang-format;
    • you have documented with doxygen any new or changed function / class;
  • you have correctly updated the copyright headers:
    • your institution is in the copyright header of every file you (substantially) modified;
    • you have checked that the end-year of the copyright there is the current one;
  • you have updated the AUTHORS file:
    • you have added yourself to the AUTHORS file;
    • if this is a new contribution, you have added it to the AUTHORS file;
  • you have added everything to the user documentation:
    • any new CMake configuration option;
    • any change in the yaml config;
    • any change to the public or plugin API;
    • any other new or changed user-facing feature;
    • any change to the dependencies;
  • you have correctly linked your MR to one or more issues:
    • your MR solves an identified issue;
    • your commit contain the Fix #issue keyword to autoclose the issue when merged.

@JAuriac JAuriac linked an issue Feb 20, 2025 that may be closed by this pull request
@jbigot
Copy link
Member

jbigot commented Feb 24, 2025

Warning you're updating the tutorial. This is unrelated

Copy link
Member

@benoitmartin88 benoitmartin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is almost ready for merge. Just a few changes are needed.

@JAuriac
Copy link
Contributor Author

JAuriac commented Feb 25, 2025

Warning you're updating the tutorial. This is unrelated

The tutorial previously used broke the CI.

@JAuriac
Copy link
Contributor Author

JAuriac commented Feb 26, 2025

Warning you're updating the tutorial. This is unrelated

The tutorial previously used broke the CI.

Changing back to tutorial @ 7334107.

benoitmartin88
benoitmartin88 previously approved these changes Dec 4, 2025
Copy link
Member

@benoitmartin88 benoitmartin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Yushan-Wang
Yushan-Wang previously approved these changes Dec 5, 2025
@Yushan-Wang Yushan-Wang added this to the v1.10.0 milestone Dec 9, 2025
@JAuriac JAuriac dismissed stale reviews from Yushan-Wang and benoitmartin88 via 237f3ae December 17, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a mechanism to deactivate PDI on demand

6 participants