Conversation
Owner
|
Looks like it should be fairly simple to generate that pattern algorithmically? I suggest using numpy arrays rather than building your own with nested lists (colormatrix in particular) For sparse patterns like this it's more efficient to use cube.clear, and just populate the colored pixels. The name in the comment at the top of the file doesn't match that used elsewhere :-) self.filling_color looks like a copy/paste remnant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey. Dan from York Hackspace, The cube is awesome and I wanted to make a pattern for it. I have made "curtain". It's mostly just a big look up table and the colours aren't great but the animation looks okay. I might try and make the colour look better.