Skip to content

Conversation

@navin-math
Copy link
Contributor

All Submissions:

  • Added get wallet balance api (v6) to SDK
  • Have you followed the guidelines in our Contributing document?
  • Have you read and signed the automated Contributor's License Agreement?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@ghost
Copy link

ghost commented May 4, 2022

Black Duck Security Report

Merging #170 into master will not change security risk.

Added Components

Clean: 12

Click here to see full report

@CLAassistant
Copy link

CLAassistant commented May 4, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ chao-chang-paypay
❌ navin-math
You have signed the CLA already but the status is still pending? Let us recheck it.

this.preference = preference;
}

@Override

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@@ -0,0 +1,99 @@
package jp.ne.paypay.model;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 10 locations. Consider refactoring.


private Call checkWalletBalanceValidateBeforeCall(String userAuthorizationId, Integer amount, String currency, ProductType productType) throws ApiException {

private Call validateCheckWalletBalanceParamsBeforeCall(String endpoint, String userAuthorizationId, Integer amount, String currency, ProductType productType) throws ApiException {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method validateCheckWalletBalanceParamsBeforeCall has 5 arguments (exceeds 4 allowed). Consider refactoring.

*/
private Call checkWalletBalanceCall(String userAuthorizationId, Integer amount, String currency,
private Call walletBalanceCall(String endpoint, String userAuthorizationId, Integer amount, String currency,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method walletBalanceCall has 5 arguments (exceeds 4 allowed). Consider refactoring.

this.cashbackAutoInvestment = cashbackAutoInvestment;
}

@Override

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method equals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented May 4, 2022

Code Climate has analyzed commit ae41ef6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 84.6% (5% is the threshold).

This pull request will bring the total coverage in the repository to 86.4% (0.0% change).

View more on Code Climate.

this.data = data;
}

@Override

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method equals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Copy link
Contributor

@curtisfennerpaypay curtisfennerpaypay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the documentation in the readme and in the docs/ folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants