Skip to content

Fix invalid iOS device token decoding before sending to Intercom #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mabdurrahman wants to merge 3 commits into
base: resolve_conflicts_2.3.2
Choose a base branch
from
Open

Fix invalid iOS device token decoding before sending to Intercom #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
124b2bf
Fix invalid token decoding
mabdurrahman Dec 23, 2020
f83f26e
Fix old Intercom sdk dependency
mabdurrahman Dec 23, 2020
6e8c7aa
Enable Intercom debugging in debug builds
mabdurrahman Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions ios/Classes/IntercomFlutterPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ + (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar>*)registrar {
UnreadStreamHandler* unreadStreamHandler =
[[UnreadStreamHandler alloc] init];
[unreadChannel setStreamHandler:unreadStreamHandler];

#if DEBUG
[Intercom enableLogging];
#endif
}

- (instancetype)initWithChannel:(FlutterMethodChannel *)channel {
Expand Down Expand Up @@ -153,11 +155,6 @@ - (void) handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
else if([@"displayMessageComposer" isEqualToString:call.method]) {
NSString *message = call.arguments[@"message"];
[Intercom presentMessageComposer:message];
} else if([@"sendTokenToIntercom" isEqualToString:call.method]){
NSString *token = call.arguments[@"token"];
NSData* encodedToken=[token dataUsingEncoding:NSUTF8StringEncoding];
[Intercom setDeviceToken:encodedToken];
result(@"Token set");
}
else if([@"sendTokenToIntercom" isEqualToString:call.method]) {
NSString *token = call.arguments[@"token"];
Expand Down
1 change: 0 additions & 1 deletion ios/intercom_flutter.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ A new flutter plugin project.
s.dependency 'Flutter'
s.dependency 'Intercom'
s.static_framework = true
s.dependency 'Intercom', '~> 7.1.0'
s.ios.deployment_target = '10.0'
end