bugfix(openmodal) fix building issue by adding if statements in mount…

[wendyprogramic]

…ing and unmounting children

Please provide enough information so that others can review your pull request:

Motivation

Explain the motivation for making this change. What existing problem does the pull request solve?
I got an error when building the app, this seems to fix it.

[paufau]

Could you please provide more details about XCode and iOS version you are using to c create the build?

[wendyprogramic]

It happens when i run 'expo run:ios' (after a prebuild). I am using the following versions:
"expo": "^53.0.0",
"react-native": "0.79.5".

The error I got was:
NSInternalInconsistencyException: RCTTouchHandler already has attached view.
0 CoreFoundation 0x00000001804b910c __exceptionPreprocess + 172
1 libobjc.A.dylib 0x0000000180092da8 objc_exception_throw + 72
2 Foundation 0x0000000180e67e68 -[NSMutableDictionary(NSMutableDictionary) classForCoder] + 0
3 NetOS.debug.dylib 0x00000001063132b8 -[RCTSurfaceTouchHandler attachToView:] + 280
4 NetOS.debug.dylib 0x000000010730c910 -[RNTModalViewComponentView mountChildComponentView:index:] + 100
5 NetOS.debug.dylib 0x00000001062964f0 _ZL27RCTPerformMountInstructionsRKNSt3__16vectorIN8facebook5react18ShadowViewMutationENS_9allocatorIS3_EEEEP24RCTComponentViewRegistryR41RCTMountingTransactionObserverCoordinatori + 1140
6 NetOS.debug.dylib 0x0000000106296070 _ZZ41-[RCTMountingManager performTransaction:]ENK3$_1clERKN8facebook5react19MountingTransactionERKNS1_16SurfaceTelemetryE + 80
7 NetOS.debug.dylib 0x0000000106296014 _ZNSt3__18__invokeB8de180100IRZ41-[RCTMountingManager performTransaction:]E3$1JRKN8facebook5react19MountingTransactionERKNS4_16SurfaceTelemetryEEEEDTclclsr3stdE7declvalIT_EEspclsr3stdE7declvalIT0_EEEEOSB_DpOSC + 40
8 NetOS.debug.dylib 0x0000000106295fbc _ZNSt3__128__invoke_void_return_wrapperIvLb1EE6__callB8de180100IJRZ41-[RCTMountingManager performTransaction:]E3$1RKN8facebook5react19MountingTransactionERKNS6_16SurfaceTelemetryEEEEvDpOT + 40
9 NetOS.debug.dylib 0x0000000106295f88 _ZNSt3__110__function12__alloc_funcIZ41-[RCTMountingManager performTransaction:]E3$1NS_9allocatorIS2_EEFvRKN8facebook5react19MountingTransactionERKNS6_16SurfaceTelemetryEEEclB8de180100ES9_SC + 44
10 NetOS.debug.dylib 0x0000000106294e04 _ZNSt3__110__function6__funcIZ41-[RCTMountingManager performTransaction:]E3$1NS_9allocatorIS2_EEFvRKN8facebook5react19MountingTransactionERKNS6_16SurfaceTelemetryEEEclES9_SC + 44
11 NetOS.debug.dylib 0x0000000106b2d448 ZNKSt3__110__function12__value_funcIFvRKN8facebook5react19MountingTransactionERKNS3_16SurfaceTelemetryEEEclB8de180100ES6_S9 + 84
12 NetOS.debug.dylib 0x0000000106b2c3ac ZNKSt3__18functionIFvRKN8facebook5react19MountingTransactionERKNS2_16SurfaceTelemetryEEEclES5_S8 + 40
13 NetOS.debug.dylib 0x0000000106b2c1dc ZNK8facebook5react19TelemetryController15pullTransactionERKNSt3__18functionIFvRKNS0_19MountingTransactionERKNS0_16SurfaceTelemetryEEEESD_SD + 300
14 NetOS.debug.dylib 0x000000010628e678 -[RCTMountingManager performTransaction:] + 564
15 NetOS.debug.dylib 0x000000010628e394 -[RCTMountingManager initiateTransaction:] + 428
16 NetOS.debug.dylib 0x000000010628dd70 __42-[RCTMountingManager scheduleTransaction:]_block_invoke + 324
17 NetOS.debug.dylib 0x000000010688c7f4 __RCTExecuteOnMainQueue_block_invoke + 40
18 libdispatch.dylib 0x000000018017b314 _dispatch_call_block_and_release + 24
19 libdispatch.dylib 0x000000018017cc08 _dispatch_client_callout + 16
20 libdispatch.dylib 0x000000018018bc2c _dispatch_main_queue_drain + 1276
21 libdispatch.dylib 0x000000018018b720 _dispatch_main_queue_callback_4CF + 40
22 CoreFoundation 0x000000018041cdbc CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE + 12
23 CoreFoundation 0x0000000180417318 __CFRunLoopRun + 1944
24 CoreFoundation 0x0000000180416704 CFRunLoopRunSpecific + 552
25 GraphicsServices 0x0000000190604b10 GSEventRunModal + 160
26 UIKitCore 0x0000000185b39180 -[UIApplication _run] + 796
27 UIKitCore 0x0000000185b3d378 UIApplicationMain + 124
28 NetOS.debug.dylib 0x0000000105d43f90 __debug_main_executable_dylib_entry_point + 64
29 dyld 0x0000000100c49410 start_sim + 20
30 ??? 0x000000010098a274 0x0 + 4304970356
31 ??? 0x9914000000000000 0x0 + 11030441387337187328
[CoreFoundation] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'RCTTouchHandler already has attached view.'
*** First throw call stack:
(
0 CoreFoundation 0x00000001804b910c __exceptionPreprocess + 172
1 libobjc.A.dylib 0x0000000180092da8 objc_exception_throw + 72
2 Foundation 0x0000000180e67e68 -[NSMutableDictionary(NSMutableDictionary) classForCoder] + 0
3 NetOS.debug.dylib 0x00000001063132b8 -[RCTSurfaceTouchHandler attachToView:] + 280
4 NetOS.debug.dylib 0x000000010730c910 -[RNTModalViewComponentView mountChildComponentView:index:] + 100
5 NetOS.debug.dylib 0x00000001062964f0 _ZL27RCTPerformMountInstructionsRKNSt3__16vectorIN8facebook5react18ShadowViewMutationENS_9allocatorIS3_EEEEP24RCTComponentViewRegistryR41RCTMountingTransactionObserverCoordinatori + 1140
6 NetOS.debug.dylib 0x0000000106296070 _ZZ41-[RCTMount<…>

[paufau]

Hi @wendyprogramic , sorry for the late reply.

Any chance you could update the minor library versions and check again?
expo: 53.0.22 +
react-native: 0.79.6 +
react-native-multiple-modals: 3.2.1 ?

[wendyprogramic]

Hi @wendyprogramic , sorry for the late reply.

Any chance you could update the minor library versions and check again? expo: 53.0.22 + react-native: 0.79.6 + react-native-multiple-modals: 3.2.1 ?

@paufau yes that works, thank you so much :)