Merged
Conversation
dlabaj
approved these changes
Nov 21, 2025
Member
rebeccaalpert
left a comment
rebeccaalpert
left a comment
There was a problem hiding this comment.
Landmarks and articles menus in VoiceOver say "Product onboarding onboarding walkthrough." I'm guessing is is from the combination of these two:
ariaLabel="Product onboarding"
ariaRoleDescription="onboarding walkthrough"
Just small potatoes.
| import Deck, { DeckButton } from '@patternfly/react-component-groups/dist/dynamic/Deck'; | ||
| import { ButtonVariant } from '@patternfly/react-core'; | ||
|
|
||
| export const BasicExample: FunctionComponent = () => { |
Member
There was a problem hiding this comment.
Suggested change
| export const BasicExample: FunctionComponent = () => { | |
| export const DeckExample: FunctionComponent = () => { |
|
|
||
| /** | ||
| * extends PatternFly's ButtonProps | ||
| */ |
| variant="small" | ||
| {...modalProps} | ||
| > | ||
| <ModalBody> |
Member
There was a problem hiding this comment.
Do we want to pass ModalBodyProps?
Contributor
Author
|
Thanks @rebeccaalpert I'll open up a clean up issue/PR to address |
|
🎉 This PR is included in version 6.4.0-prerelease.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #825
New documentation / examples for the component
Demo of an onboarding modal deck which more closely matches figma designs.