fix(SkeletonTableHead): prevent nested th elements when passing Th components#821
Merged
nicolethoen merged 1 commit intopatternfly:mainfrom Oct 9, 2025
Conversation
…mponents When React elements (like <Th>) were passed in the columns prop, they were being wrapped in an additional <Th> element, causing invalid DOM structure with nested <th> elements. This fix checks if a column is already a React element and renders it directly without wrapping it in an additional Th component. Fixes patternfly#764 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
karelhala
approved these changes
Oct 9, 2025
|
🎉 This PR is included in version 6.4.0-prerelease.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When React elements (like ) were passed in the columns prop, they were being wrapped in an additional element, causing invalid DOM structure with nested elements.
This fix checks if a column is already a React element and renders it directly without wrapping it in an additional Th component.
Closes #764
Generated with Claude Code