fix(NotFoundIcon): Fix missing page icon in dark mode#677
Merged
nicolethoen merged 1 commit intopatternfly:mainfrom Apr 2, 2025
logonoff:found
Merged
fix(NotFoundIcon): Fix missing page icon in dark mode#677nicolethoen merged 1 commit intopatternfly:mainfrom logonoff:found
nicolethoen merged 1 commit intopatternfly:mainfrom
logonoff:found
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the display issue of the NotFoundIcon in dark mode by replacing the custom SVG implementation with the PatternFly PathMissingIcon component.
- Replaces the manually defined SVG paths with the PatternFly icon.
- Updates the styling to apply a fixed height and width to the icon.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the missing page icon in dark mode by replacing the custom SVG implementation with PatternFly's PathMissingIcon component.
- Imports PathMissingIcon from the PatternFly library
- Simplifies the NotFoundIcon component to render the new icon with appropriate styling
- Removes the legacy custom SVG markup
dlabaj
approved these changes
Apr 2, 2025
nicolethoen
approved these changes
Apr 2, 2025
|
🎉 This PR is included in version 6.2.0-prerelease.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
after:
