Upgrade silverstripe-gridfieldlimititems to SS4#6
Upgrade silverstripe-gridfieldlimititems to SS4#6MasseyIsaako wants to merge 7 commits intopatricknelson:masterfrom
Conversation
MasseyIsaako
changed the title
code/GridFieldLimitItems.php
Outdated
| $this->onAfterManipulate(function(GridField $grid, SS_List $list){ | ||
| if ($list->count() == $this->getMaxItems()) { | ||
| // var_dump($grid->getConfig()); | ||
| // die(); |
There was a problem hiding this comment.
Should probably tidy up and remove these lines :-)
patricknelson
left a comment
patricknelson
left a comment
There was a problem hiding this comment.
Hi, thank you so much for the work on this! I've yet to update my own instance of SS to v4 (on roadmap, long story). It's for this reason that there's been such a severe delay in following up on this since I haven't taken time to setup a separate instance of SS to test these changes, however, I'll do what I can to try and stay on top of this.
| @@ -1,2 +1 @@ | |||
| <?php | |||
| // Noop. | |||
There was a problem hiding this comment.
This is here on purpose; the point is to reinforce the fact that this file is here and intentionally blank (hence the "noop", short for "no operation").
| } | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
I believe there's a separate pull request to address this feature. For cleanliness and organization, and since this is open source, could you update this particular PR branch to not include the enforceLimit feature? Particularly since there could be divergence between the two PR's (haven't checked yet).
|
Also, documenting here for my reference 😄 TODO: Separate code into two major branches:
|
3 participants
…r as SS_Log is deprecated.