Skip to content

small changes to ensure handle closure & dir deletion #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickjburke245 merged 4 commits into from
Feb 16, 2025
Merged

small changes to ensure handle closure & dir deletion #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5684c0e
small changes to ensure handle closure & dir deletion
neilcar Feb 9, 2025
8ea850c
adding defer file.Close()
neilcar Feb 9, 2025
d6f30f5
fixing the fix
neilcar Feb 9, 2025
b3de324
adding exemptions for semgrep/opengrep findings
neilcar Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions get_vuln.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import (
"context"
"github.com/google/go-github/v57/github"
"log"
// don't need cryptographically secure random here
// nosemgrep: go.lang.security.audit.crypto.math_random.math-random-used
"math/rand/v2"
"os"
"path/filepath"
Expand Down
25 changes: 16 additions & 9 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ import (
"github.com/joho/godotenv"
"golang.org/x/oauth2"
"log"
"math/rand"
// don't need cryptographically secure random here
// nosemgrep: go.lang.security.audit.crypto.math_random.math-random-used
"math/rand/v2"
"os"
"strconv"
"strings"
Expand Down Expand Up @@ -43,7 +45,7 @@ func main() {

_, pythonPackage, pythonVersion := getPythonVuln(githubPersonalAccessToken)

bugId := strconv.Itoa(rand.Intn(3000))
bugId := strconv.Itoa(rand.IntN(3000))

if commitMsg == "<auto>" {
commitMsg = generateCommit("Generate a short, complete commit message for a Git commit fixing a specific bug with bug ID" + bugId)
Expand Down Expand Up @@ -79,7 +81,14 @@ func main() {
return
}
}

// ensure cleanup of repo folder
defer func() {
dirRemovalErr := os.RemoveAll("./terragoat")
if dirRemovalErr != nil {
log.Fatal(err)
}
fmt.Printf("Successfully removed directory.\n")
}()
// Create and checkout new branch
w, err := repo.Worktree()
if err != nil {
Expand All @@ -102,6 +111,10 @@ func main() {
exampleFile := "./terragoat/example2.tf"
fmt.Printf("Creating file: %s\n", exampleFile)
content, err := os.ReadFile("new_resource.tf")
if err != nil {
fmt.Printf("Error opening file: %s\n", err)
return
}
err = os.WriteFile(exampleFile, content, 0644)
if err != nil {
fmt.Printf("Error creating file: %s\n", err)
Expand Down Expand Up @@ -173,12 +186,6 @@ func main() {

fmt.Printf("Successfully created PR #%d\n", pr.GetNumber())
fmt.Printf("PR URL: %s\n", pr.GetHTMLURL())

dirRemovalErr := os.RemoveAll("./terragoat")
if dirRemovalErr != nil {
log.Fatal(err)
}
fmt.Printf("Successfully removed directory.\n")
}

func GetCode(branchPrefix string, repoURL string, githubPersonalAccessToken string) (string, *git.Repository, *http.BasicAuth, error) {
Expand Down
Loading