Skip to content

Fix: Sparse Adjancency too small if graph contains isolated nodes #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
M-Lampert merged 1 commit into from
Dec 20, 2024
Merged

Fix: Sparse Adjancency too small if graph contains isolated nodes #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pathpyG/core/graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def sparse_adj_matrix(self, edge_attr: Any = None) -> Any:
scipy.sparse.coo_matrix: sparse adjacency matrix representation of graph
"""
if edge_attr is None:
return torch_geometric.utils.to_scipy_sparse_matrix(self.data.edge_index.as_tensor())
return torch_geometric.utils.to_scipy_sparse_matrix(self.data.edge_index.as_tensor(), num_nodes=self.n)
else:
return torch_geometric.utils.to_scipy_sparse_matrix(
self.data.edge_index.as_tensor(), edge_attr=self.data[edge_attr], num_nodes=self.n
Expand Down
10 changes: 10 additions & 0 deletions tests/core/test_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,16 @@ def test_sparse_adj_matrix(simple_graph):
assert weighted_adj.data[1] == 1
assert weighted_adj.data[2] == 2

g = Graph.from_edge_index(torch.tensor([[0], [1]]), num_nodes=5)
adj = g.sparse_adj_matrix()
assert adj.shape == (5, 5)
assert adj.nnz == 1

g.data.edge_attr = torch.tensor([[1]])
adj = g.sparse_adj_matrix("edge_attr")
assert adj.shape == (5, 5)
assert adj.nnz == 1


def test_degrees(simple_graph):
in_degrees = simple_graph.degrees("in")
Expand Down
Loading