-
Notifications
You must be signed in to change notification settings - Fork 0
E2E foundation, contracts, and CI #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Ready Queue no longer includes scaffold task at top. Ensure Dev CLI timestamps align (complete_task uses timezone-aware ISO8601).
…ontracts, CI tighten, docs - Add Playwright config/global setup already in repo; add browse.spec.ts and scan.spec.ts specs using stable data-testid hooks - Fix scan E2E assertions to avoid regex pitfalls and allow multiple occurrences - Add API contracts for /api/scan, /api/scans/<id>/status, /api/directories - Make E2E job strict in CI; document in docs/testing.md and add PR template - Align Dev CLI timestamps and finalize task:e2e:02-playwright-scaffold bookkeeping
Owner
Author
|
E2E implemented and built into dev cycle using Playwright and automations, and all tests are passing. |
…); chore: add pytest markers; deps: playwright, pytest-playwright, requests in pyproject optional [dev] and requirements.txt; ci: add GitHub Actions e2e workflow
…eutil runtime deps; add optional llm extras; e2e: add Makefile targets and README docs for Playwright tests
… (7687). Docs: update instructions to access UI at :7474 and connection notes.
…(Docker Hub repo does not exist)
…mount points and image registry notes
…ument non-root overrides
…474 to 8080 and update docs
… container; align mounts with Neo4j Docker volume guidelines
… with APOC only; update Singularity def accordingly. Docs in dev/ remain in submodule and were not committed here.
…al Playwright tmp/cache; Makefile E2E targets; add bootstrap-dev.sh; pin E2E downloads path in tests/e2e/conftest.py
…k.toml folder-config precedence; annotations REST endpoints with pagination/privacy; UI tweaks; tighten pytest markers
…; map/datasets testids; align E2E selectors; add persistence E2E; add folder-config/annotations/selective-cache tests; update pytest markers in pyproject
…test-runs, playwright-report, test-results, pytest-of-patch, sqlite:/, (pwd)/); prevent staging transient files
…test-runs, playwright-report, test-results, pytest-of-patch, sqlite:/, (pwd)/); prevent staging transient files
…ixture (imports os/sys/collections, adds foo() and Bar class, and module docstring). Ensure unit tests pass locally.
- E2E: use stable data-testids for graph and scan workflows - tests: pin E2E to Chromium and repo-local PLAYWRIGHT_BROWSERS_PATH - Makefile: unit/integration/e2e use repo-local TMPDIR and pytest --basetemp - CI: matrix tiers set TMPDIR and --basetemp; upload E2E artifacts on failure - git: untrack stray sqlite:/:memory:; .gitignore guards repo-local artifacts
… browsers repo-locally; pin Ubuntu runner to 22.04; keep TMPDIR and --basetemp repo-local across tiers
…; remove deprecated action; keep repo-local TMPDIR/--basetemp
… e2e job; keep repo-local TMPDIR and --basetemp
…test flag; keep repo-local TMPDIR/basetemp
…hromium with deps via npx; keep repo-local paths
…re install; use repo-local TMP/TMPDIR/TEMP and PLAYWRIGHT_BROWSERS_PATH; remove invalid pytest flag
…ackage; ensure repo-local TMPDIR/TMP/TEMP and PLAYWRIGHT_BROWSERS_PATH; fix chromium missing executable on Actions
…add requests to runtime deps; align pytest markers\n- requirements.txt/requirements-dev.txt: add helpers for installs\n- README.md: quickstart and testing docs updates (avoid installing pyproject.toml)\n- remove stray test-results/.last-run.json
…n- tests/test_providers_api.py: mark test_list_providers, test_browse_local_root\n- tests/contracts/test_api_contracts.py: mark test_provider_roots_contract_local_fs, test_browse_contract_local_fs_root_listing\n\nEnsures these run under the integration tier with SCIDK_PROVIDERS=local_fs and are excluded from unit.
Owner
Author
|
Took a while to get the e2e working correctly but all good now - especially with regard to all the playwright installs (alongside typical python). It may be more cumbersome than it's worth! Now, we do have all the installations working right and some learning on how to use CI workflows, as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: E2E foundation, contracts, and CI
Summary
Related
Local verification
CI
How to run locally
Risk assessment
Merge checklist
Post-merge (follow-up branch)