Skip to content

Conversation

@jiedxu
Copy link
Collaborator

@jiedxu jiedxu commented Jul 30, 2020

No description provided.

@jiedxu jiedxu requested a review from zequnyu July 30, 2020 13:48
@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #61 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   87.32%   87.45%   +0.13%     
==========================================
  Files          11       11              
  Lines         284      287       +3     
==========================================
+ Hits          248      251       +3     
  Misses         36       36              
Impacted Files Coverage Δ
src/cmdict/pdf_tools.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0320278...7bb4463. Read the comment docs.

@jiedxu jiedxu linked an issue Jul 30, 2020 that may be closed by this pull request
Copy link
Collaborator

@zequnyu zequnyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was testing this, color match is not correct. Other than that, can you make sure this works in bash, iTerm2 etc?

@zequnyu
Copy link
Collaborator

zequnyu commented Jul 30, 2020

If this turns out to be working, we can go ahead and replace colorama with it.

@jiedxu jiedxu marked this pull request as draft April 15, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Print extracted words in the highlighted colour

3 participants