camelCase transaction status to align with Substrate#3105
Open
Conversation
Contributor
twiggy diff reportDifference in .wasm size before and after this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! An error cropped up via Ink in trying to use Subxt to communicate with Smoldot:
I believe the reason for the issue was that Smoldot's
author_submitAndWatchExtrinsicreturns transaction statuses whose variants aren't camelCased, whereas the Substrate RPC method does camelCase (see https://github.com/paritytech/substrate/blob/283106b19b85bc8deb232cfa624eed195f143541/client/transaction-pool/api/src/lib.rs#L106)So I wonder whether you'd be open to applying the same camelCasing in Smoldot to align?