Make signature verification customizable in the host module#2955
Merged
mergify[bot] merged 9 commits intoparitytech:mainfrom Nov 1, 2022
Merged
Make signature verification customizable in the host module#2955mergify[bot] merged 9 commits intoparitytech:mainfrom
mergify[bot] merged 9 commits intoparitytech:mainfrom
Conversation
Contributor
twiggy diff reportDifference in .wasm size before and after this pull request. |
Contributor
Author
|
I also did |
Contributor
|
This is indeed better. Will try integrate this. |
Contributor
|
Because I am using smoldot/src/executor/runtime_host.rs Line 160 in 6df249e |
melekes
reviewed
Nov 1, 2022
melekes
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @xlc
After looking at #2952, I thought that the approach in this PR is a better idea.
As shown in the changes to
runtime_host.rsandread_only_runtime_host.rs, you now have a new variant calledSignatureVerificationthat allows you to overwrite the verification if you so desire.As I was implemented this PR, I noticed that the implementation of
ext_crypto_ecdsa_verifyloads the message from the first parameter, which is actually the signature. Oops. This is fixed at the same time.