Remove unused fallback protocol names system#2569
Merged
mergify[bot] merged 4 commits intoparitytech:mainfrom Jul 29, 2022
Merged
Remove unused fallback protocol names system#2569mergify[bot] merged 4 commits intoparitytech:mainfrom
mergify[bot] merged 4 commits intoparitytech:mainfrom
Conversation
Contributor
Author
|
It turns out that this was even mis-implemented. |
Contributor
twiggy diff reportDifference in .wasm size before and after this pull request. |
melekes
approved these changes
Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ages ago, I added a dummy field called
fallback_protocol_namesthat lets you specify a list of alternative protocol names that would be negotiated if the main one isn't supported by the remote.Substrate has a similar feature, and it's very useful in order to do protocol upgrades. (e.g. #2116)
Unfortunately this has never been implemented.
Instead of leaving this dummy feature here, this PR just removes it. It can always be added back properly in the future.