fix: don't use generated name for hook #412
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where ArgoCD hooks were using generated names, causing multiple job instances to be created. The fix ensures hooks use deterministic names and updates the default hook deletion policy to BeforeHookCreation to prevent duplicate jobs.
Key Changes:
- Removed
generateNamefor ArgoCD hooks in favor of static names - Changed default
hookDeletePolicyfromHookSucceededtoBeforeHookCreation - Added proper quoting to hook annotation values
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| parcellab/common/templates/_job.tpl | Removed conditional name generation logic; unified to use static name and updated hook delete policy default |
| parcellab/monolith/values.yaml | Updated example documentation to reflect the new default hook delete policy |
| parcellab/common/Chart.yaml | Bumped chart version to 1.0.77 |
andibeuge
left a comment
andibeuge
left a comment
There was a problem hiding this comment.
In order to populate this change to the charts: please update the versions in the charts monolith, microservice, workers etc as well
Ah yes, forgot about that part. |
|
because why not :D |
Using the generated name at least for a PostDelete hook was problematic, created too many jobs. I think in the case of ArgoCD hooks, we want the names to be unique?
gersmann
force-pushed
the
fix/unique-hook-names/sg
branch
from
f50295b to
6852ee2
Compare
done |
|
@andibeuge can you recheck pls? |
Using the generated name at least for a PostDelete hook was problematic, created too many jobs. I think in the case of ArgoCD hooks, we want the names to be unique?