Conversation
|
Listing each directory explicitly under Using explicit relative path while invoking the compiler seems a bit odd as well. |
|
If you don't mention the directories, then the screen is filled with warnings, though the tests will still pass. I added the explicit path to the encore compiler to make sure that it was running the right one — perhaps this is redundant and handled already by the testing script. |
kikofernandez
left a comment
There was a problem hiding this comment.
Looks good but I won't merge until the author confirms if a Makefile is needed to do the stress testing. If the author fixes this issue before 15.00, I'll merge today
|
|
||
| run: main | ||
| /usr/bin/time ./main | ||
|
|
There was a problem hiding this comment.
Is this Makefile needed by the CI?
There was a problem hiding this comment.
Yes, because there is no other way to pass the -O3 flag to the compiler.
(Whether the -O3 flag is really required is a question for the BoundedBuffer implementor.)
The reason for tidying up the Makefile was to reduce errors in the output, and increase faith in make stress.
77ca53d to
c7e22e3
Compare
|
@kikofernandez Ping! |
|
@kikofernandez Are you fishing for more cake? |
|
CI fails Sent from my Samsung GT-I9506 using FastHub |
|
CI fails because I keep updating src/tests/IGNORED_FILES.grep whenever I add new (stress) tests. |
f108e11 to
2d4449b
Compare
Added entries into IGNORED_FILES.grep to reduce number of warning produced when running stress tests.
Made one Makefile a little more robust.