Skip to content

Include values for boolean (type 5) demographics #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zarathustra323 merged 1 commit into from
Dec 11, 2025
Merged

Include values for boolean (type 5) demographics #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/api-client/src/entities/brand/demographic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ const builder = ({ name, value, parent }) => {
// force an empty array for non-choice demographics.
// the Omeda API returns an array with a single value object, containing
// an Id of 0 (which is invalid)
if (![1, 2].includes(parent.DemographicType)) return [];
// also include boolean values (type 5) since these also use value IDs
if (![1, 2, 5].includes(parent.DemographicType)) return [];
return asArray(value).map((obj) => new DemographicValue(obj));
}
return null;
Expand Down
Loading