Improve UseWaitCursor true/false

[NoNod]

Sometimes the spinning wait cursor stays on.
This will fix it.

[ErikMogensen]

Sorry for the late review, @NoNod. Do you know why the current code isn't working? I see it resetting the cursor in finally blocks, which should work. I do know it doesn't.

[ErikMogensen]

I ran the PR through Copilot which stated:

Consider renaming from DisposableUseWaitCursor to WaitCursorScope or UseWaitCursorScope. "Disposable" in a type name is redundant because IDisposable is the pattern; e.g. WaitCursorScope is clearer.

I think that is a good idea.

[AnyTick]

Explicit On/Off WaitCursor calls work fine within try-finally blocks. However, the try-finally block was missed in the DoPurge method. As a result, the cursor wasn't reset when an exception occurred in DoPurge.

WaitCursorScope is a much better name. 😉 I think implementing the WaitCursor logic as an IDisposable class makes the code more readable than handling it with try-finally blocks.

[ErikMogensen]

This makes the code cleaner.

Copilot suggested that the cursor class should use reference counting to support nesting, but I suggest that is done in another PR - if we see a need for it.