Conversation
speculatingwook
approved these changes
Jun 29, 2025
speculatingwook
left a comment
speculatingwook
left a comment
There was a problem hiding this comment.
저번보다 확실히 나아졌습니다.! 다만, 아직은 객체들이 협력하는 구조인지 한눈에 파악하기 힘듭니다. 제가 전체 코드베이스를 보고 나서 구두로 말씀드리겠습니다. 일단 객체 다이어그램이라던지, 객체들간의 관계과 역할에 대해 조금 더 다듬는 것이 좋아보입니다.!!
고생하셨습니다!
docs/README.md
Outdated
| - `guess : List<Integer> ` | ||
| - `correct : List<Integer> ` | ||
|
|
||
| ## Start 클래스 |
| public String checkBallsAndStrikes(List<Integer> correct,List<Integer> guess){ | ||
| List<Integer> numberOfStrike = ballCounting.getStrike(correct,guess); | ||
| List<Integer> numberOfBall = ballCounting.getBall(correct,guess); | ||
| strike =""; |
There was a problem hiding this comment.
GameHost의 이름이 예상되는 역할과 일치하지 않는다는 느낌이 듭니다.!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.