Skip to content

Exception handling#4

Open
jonasgit wants to merge 24 commits intopajp:masterfrom
jonasgit:master
Open

Exception handling#4
jonasgit wants to merge 24 commits intopajp:masterfrom
jonasgit:master

Conversation

@jonasgit
Copy link
Contributor

This is a quick fix. You may wish to consider a better handling.

@pajp
Copy link
Owner

pajp commented Feb 23, 2012

Thanks for your contribution! However, I'm not sure if you meant to make a pull request pointing to your 'master' branch, as a pull request is associated with a branch head rather than that branch's head at a certain point in time. That is, as you make more commits to your master branch, this pull request will be updated automatically. I believe you only meant to request a pull of commits 3f8e7a3 and b1ec19d but now I see f86edb8 and b43378e as well.

Anyway, I'll review the exception handling when I get the time and see if I want to make any other additions to hit.

@jonasgit
Copy link
Contributor Author

On Thu, 23 Feb 2012, Rasmus Sten wrote:

Thanks for your contribution! However, I'm not sure if you meant to make a pull request pointing to your 'master' branch, as a pull request is associated with a branch head rather than that branch's head at a certain point in time. That is, as you make more commits to your master branch, this pull request will be updated automatically. I believe you only meant to request a pull of commits 3f8e7a3 and b1ec19d but now I see f86edb8 and b43378e as well.

Anyway, I'll review the exception handling when I get the time and see if I want to make any other additions to hit.

Jag är inte så bra på git så jag kan mycket väl ha gjort fel.
Ursprungligen var det en catch exception som jag lade till och då skrev
kommentaren. Sedan lade jag till ett par funktioner också som inte har med
kommentaren att göra utan är ren funktionsutökning, men de kom väl med på
samma pull request och det är förstås fel egentligen. Däremot ser jag
gärna att de kommer med i lattekom ändå förstås.

/Jonas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments