Fairly simple, demographics implemented, all green#8
Open
sampriddy wants to merge 8 commits intopaircolumbus:masterfrom
sampriddy:master
Open
Fairly simple, demographics implemented, all green#8sampriddy wants to merge 8 commits intopaircolumbus:masterfrom sampriddy:master
sampriddy wants to merge 8 commits intopaircolumbus:masterfrom
sampriddy:master
Conversation
added 8 commits
December 13, 2015 14:23
Contributor
There was a problem hiding this comment.
100 is used throughout this file but to someone reading it might appear as a 'magic number'. You might want to use a constant to make some of these formulas more readable
Member
There was a problem hiding this comment.
Good point 👍 If you also move it to a constant, you only have to make a single change if the magic values changes. Imagine a scenario where this is thousands of lines of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.