Open
Conversation
added 2 commits
October 5, 2015 13:25
Not sure how terse to go with some of the code. I'm still not 100% with accepted Ruby idioms.
Author
|
As suggested by Jay: @mikegee please review. |
gem_city.rb
Outdated
Member
There was a problem hiding this comment.
Is this hash internal such that downcasing Officers to officers won't break anything?
Member
There was a problem hiding this comment.
Actually, what about ditching the hash for two instance variables (@thieves & @officers)?
Author
There was a problem hiding this comment.
I didn't want to make changes that were not based on rubocop output. But, both of these changes would definitely improve the code.
Member
|
This is very readable now. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how terse to go with some of the code. I'm still not 100% with
accepted Ruby idioms.
@chivygab @jaybobo Please review.