Correct code to be Rubocop compliant#23
Open
RupertSaxton wants to merge 2 commits intopaircolumbus:masterfrom
Open
Correct code to be Rubocop compliant#23RupertSaxton wants to merge 2 commits intopaircolumbus:masterfrom
RupertSaxton wants to merge 2 commits intopaircolumbus:masterfrom
Conversation
mikegee
reviewed
Jan 30, 2018
gem_city.rb
Outdated
| @people = { | ||
| thieves: 5, | ||
| officers: 1 | ||
| } |
Member
There was a problem hiding this comment.
Do these two values really need to be joined into Hash? Consider the simplification if they weren't.
Author
There was a problem hiding this comment.
I had used it because that's the way it came but having them as instance variables and using attr_accessor is much nicer
mikegee
reviewed
Jan 30, 2018
gem_city.rb
Outdated
| @population = 50 | ||
| end | ||
|
|
||
| def thieves(thieves_number = @people[:thieves]) |
Member
There was a problem hiding this comment.
Officers have both a getter and setter method, but thieves just have this hybrid method. I think two methods is better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.