Open
Conversation
Contributor
|
I'd say give this one another shot. Use two spaces to indent. And see if you can't substantially reduce the amount of code, and avoid the need for the return keyword. |
Contributor
|
Looks a lot better. 👍 If you call a #split on the string first, you'll end up with an array of words, and then your regex can be a lot simpler. Also, === is probably better than =~ here. Whereas the latter returns the index of the first match, which can be cast into a boolean, the former returns a boolean directly. Just remember that it's a regexp method, so the regexp has to go on the left side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.