Open
Conversation
mikegee
reviewed
Mar 20, 2018
|
|
||
| def fetch_CD_animals(input) | ||
| #implement your solution here | ||
| input.grep(/^[cdCD].*/) |
Member
There was a problem hiding this comment.
/^[cdCD]/ would also match strings starting with "c" or "d".
Also, the regex can be marked as "case-insensitive like so: /^[cd]/i.
mikegee
reviewed
Mar 20, 2018
|
|
||
| def fetch_the_dog(input) | ||
| #implement your solution here | ||
| input.select {|a| a.casecmp("dog") == 0} |
Member
There was a problem hiding this comment.
a.downcase == "dog" is a bit simpler for the next developer to read.
mikegee
reviewed
Mar 20, 2018
|
|
||
| def capitalize_each_string(input) | ||
| #implement your solution here | ||
| input.map {|a| a.capitalize} |
Member
There was a problem hiding this comment.
Rubyists tend to write this as: input.map(&:capitalize). Google "ruby symbol to_proc" for more info. It's hard to explain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jaybobo, please review.