Open
Conversation
| else | ||
| Print::error_message | ||
| end | ||
| end |
There was a problem hiding this comment.
I think generally we should prefer structured loops (until ..., while ...), where the termination clause is explicitly defined at the beginning of the loop, rather than loop do patterns with a break tucked away somewhere in the body.
Member
|
@cmc629 it looks like you're committing a whole lot more than just the faker change. you should just have two files here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jaybobo NOT my game. Just added the faker gem to Gemfile (and the Gemfile.lock?).