Open
Conversation
|
|
||
| def get_attendance_input | ||
| serialize_attendance.tap do |obj| | ||
| obj[:date] = Date.today.to_s if obj[:date].empty? |
Author
There was a problem hiding this comment.
I wanted to add an unless obj[:date].match(/^\d{4}-\d{2}-\d{2}/) but wasn't sure how I should do the rewrite to prompt the user that their date is invalid.
Another thing I was thinking was to either split the string, or have a prompt for year, month, day, and then fork it into Date::valid_date?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to kill it with fire, but it works.