Conversation
mikegee
reviewed
May 14, 2018
| self.height += 1 | ||
| end | ||
| self.age > 8 ? self.add_apples : false | ||
| self.dead? ? self.alive = false : self.alive = true |
Member
There was a problem hiding this comment.
Flipping this around is a bit simpler, I think:
self.alive = !self.dead?
mikegee
reviewed
May 14, 2018
| end | ||
|
|
||
| def add_apples | ||
| 3.times do self.apples << Apple.new("red", rand(2..4)) end |
Member
There was a problem hiding this comment.
Rubyists tend to use curly braces for single-line blocks:
3.times { self.apples << Apple.new("red", rand(2..4)) }
Member
|
Looks really good to me! |
jaybobo
reviewed
May 15, 2018
| expect(fuji.alive).to be(true) | ||
| end | ||
|
|
||
| it 'stops growing after it is 20 feet tall' do |
Member
There was a problem hiding this comment.
looks good but keep in mind using context to clean it defs like this and make them more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jaybobo