initial commit#56
Open
robert-smith-07 wants to merge 1 commit intopaircolumbus:masterfrom
robert-smith-07:master
Open
initial commit#56robert-smith-07 wants to merge 1 commit intopaircolumbus:masterfrom robert-smith-07:master
robert-smith-07 wants to merge 1 commit intopaircolumbus:masterfrom
robert-smith-07:master
Conversation
mikegee
reviewed
Oct 13, 2017
| end | ||
|
|
||
| def add_apples | ||
| $i = 0 |
Member
There was a problem hiding this comment.
You may have intended to use a local variable here, but that $ prefix is making this a global instead. I think you can drop the $s in here.
mikegee
reviewed
Oct 13, 2017
| end | ||
|
|
||
| def age! | ||
| @age += 1 |
Member
There was a problem hiding this comment.
The attr_reader at the top exposes @age, etc. by calling methods age.
This line is both reading and assigning age if you used attr_accessor, to define the setter methods too, this line could be age += 1.
I prefer depending on the methods as much as possible. Ruby will gladly return nil for a typoed instance variable, but raises an error for a typoed method name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jaybobo
@mikegee
I know the tests are terrible, any documentation, comments, resources are appreciated.