Skip to content

Pull from stripe-ruby-mock:origin/master#3

Open
quekshuy wants to merge 2 commits intopadlet:masterfrom
stripe-ruby-mock:master
Open

Pull from stripe-ruby-mock:origin/master#3
quekshuy wants to merge 2 commits intopadlet:masterfrom
stripe-ruby-mock:master

Conversation

@quekshuy
Copy link

@quekshuy quekshuy commented Nov 7, 2025

This pull request introduces improvements to promotion code filtering and makes minor updates to gem usage and loading. The main change is the addition of case-insensitive filtering for promotion codes when listing, along with corresponding test coverage. There are also updates to the gem installation instructions and the main library file.

Promotion code filtering:

  • Added case-insensitive filtering by code when listing promotion codes in list_promotion_code, ensuring that searches match regardless of letter case.
  • Added a test to verify listing and filtering promotion codes by code in a case-insensitive manner in promotion_code_examples.rb.

Gem usage and loading:

  • Updated the gem installation instructions in README.md to remove the explicit :require => 'stripe_mock' option, simplifying usage.
  • Added a require 'stripe_mock' statement to the main stripe-ruby-mock.rb file to ensure proper loading of the gem.

@quekshuy quekshuy requested review from a team, daryllxd, julianalmandos, nvdai2401 and strawhatduckk and removed request for a team November 7, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants