Remove RNFoundation dependency and bump to 1.2.2#20
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes a dependency on RNFoundation and bumps the package version to address compatibility issues with the main mobile app. The change eliminates the need for the main app to patch the RNFoundation dependency.
- Remove the
padlet_rn-foundationproject dependency from Android build configuration - Bump package version from 1.2.1 to 1.2.2
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates version number to 1.2.2 |
| android/build.gradle | Removes the padlet_rn-foundation project dependency |
tonkatsu-wallwisher
requested review from
a team,
SaphiraNgocThuy,
asleepace,
quekshuy and
thespacemanatee
and removed request for
a team
quekshuy
approved these changes
Jul 30, 2025
Contributor
quekshuy
left a comment
quekshuy
left a comment
There was a problem hiding this comment.
After merging have to git-tag as v1.2.2
quekshuy
force-pushed
the
tonkatsu/remove-rnfoundation-requirement
branch
from
f92d672 to
1e08335
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version removes the
api project(':padlet_rn-foundation')declaration which the main mobile app is currently patching (which shouldn't really be needed).