-
Notifications
You must be signed in to change notification settings - Fork 13
Updated to work with newer Delphi versions #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
Actually if you don't mind explaining in more details what was it that you changed other than the import of fastmm and removal of include of revision.inc that made it compatible with the newer versions of Delphi? |
|
Sorry for the confusion, I should have splitted my changes in several commits. In fact the compatibility changes were just little. In fact I should have forward only these changes as a pull request. The reason why I did what you mentioned is mostly because of personal preferences, hence the personal fork. This said, I couldn't figure out how the revisions.inc worked, which is why I removed it. May I suggest to either add a .dproj file with the right configuration or a build.bat to build the project from the command line. Additionally/alternatively a howto build would be welcome in the readme.me |
|
Could you explain what made it work with new version of Delphi? I see only the change in removing fastmm4 in components and addition of submodule folder with ref to a github repo.. It'd be best to keep components inside the components folder - adding a submodules folder has little value and is jsut a technicality. |
|
The changes were related to the Pascal-Parser component. It used DecimalSeparator, which has been moved to FormatSettings.DecimalSeparator. Also there was something odd with some list access. |
|
Let's do this: let's split this into 2 PRs - one for externalizing the FastMM component (please use the Thanks! |
No description provided.