return number of processed items and Abort error#1
Open
alinz wants to merge 2 commits intopacedotdev:masterfrom
Open
return number of processed items and Abort error#1alinz wants to merge 2 commits intopacedotdev:masterfrom
alinz wants to merge 2 commits intopacedotdev:masterfrom
Conversation
Collaborator
Author
|
@matryer just wanted to see if this PR worth merging? if not let's close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@matryer Thanks for this little code which makes go shine.
I have decided to send a PR rather than creating an issue. I just wanted to know your opinions.
I have separate them in two commits.
The first one emphasized on returning Abort error. I feel like returning an Abort is the same as all items has been processed. There is no way to indicate whether all is done or it is been aborted.
The second commit focus on returning the number of processed items in batch. Similar to
io.Reader.Read()which returns the number of bytes that has been read.any thoughts on that?
cheers