fix(rust-workflows): use -W clippy::pedantic as per PR feedback#9
Open
cwtchan wants to merge 45 commits intopac-work:rust-bindingsfrom
Open
fix(rust-workflows): use -W clippy::pedantic as per PR feedback#9cwtchan wants to merge 45 commits intopac-work:rust-bindingsfrom
-W clippy::pedantic as per PR feedback#9cwtchan wants to merge 45 commits intopac-work:rust-bindingsfrom
Conversation
- The crate is supposed to serve as lower level bindings which higher level abstractions can be built upon. Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
- This layer is supposed to more or less reflect the structure of the MXL library itself and should not yet use async. Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
- Our unsafe code was way too unsafe :) Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
- Need to free up the name GrainWriter for future chages - there will be a GrainWriter and a SamplesWriter, analogically to how MXL distinguishes access to "discrete" and "continuous" flows. Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
- Added grain writer and a skeleton for samples writer. Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
- Added grain reader and a skeleton for samples reader. Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
- Currently MXL library generates a header file with it's version during the build process. This header file is not strictly needed for the Rust bindings at the moment, as it contains just constants representing the library version. - Adding a feature flag, which allows skipping this file and thus referencing MXL Rust bindings from other projects just directly from GitHub, without the need to locally build the MXL repo or even "worse" building the MXL repo fully together with bindings. Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
- This is useful when one wants to construct different readers and writers from different threads. Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
- Will simplify use of those in async contexts, especially as long as we do not have proper async interface. Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
Signed-off-by: Pavel Cernohorsky <pavel.cernohorsky@appear.net>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Owner
|
As mentioned in the "official merge PR" - would it be possible to make Clippy use this also when normally executed as |
pac-work
force-pushed
the
rust-bindings
branch
from
8b210b3 to
99a129b
Compare
pac-work
force-pushed
the
rust-bindings
branch
5 times, most recently
from
924a6cf to
4030cd2
Compare
pac-work
force-pushed
the
rust-bindings
branch
2 times, most recently
from
957bad1 to
0daf7e1
Compare
pac-work
force-pushed
the
rust-bindings
branch
2 times, most recently
from
97fd9c1 to
c56f54b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.