Compile mxl using CMake for mxl-sys crate#6
Merged
pac-work merged 8 commits intopac-work:rust-bindingsfrom Sep 18, 2025
Merged
Conversation
cwtchan
changed the title
mxl using CMake for \mxl-sys\ cratemxl using CMake for mxl-sys crate
pac-work
force-pushed
the
rust-bindings
branch
from
196fa6f to
d69f2ad
Compare
|
Thanks, @cwtchan! When I was on vacation, I thought this was the first thing I should do, so you saved me some time 🙂 |
pac-work
force-pushed
the
rust-bindings
branch
2 times, most recently
from
81d6dba to
eb83e4e
Compare
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
cwtchan
force-pushed
the
feature/compile-mxl-for-rust
branch
from
8a5dfd1 to
ce9e704
Compare
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
Signed-off-by: Chris Chan <chris.chan@techex.co.uk>
cwtchan
force-pushed
the
feature/compile-mxl-for-rust
branch
from
ce9e704 to
38a7600
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the name suggests, here we use CMake to compile `mxl` for the `mxl-sys` crate.
I took the liberty to modify some of the CMakeLists.txt files to make compilation of the tests and tools optional.