Address some of the comments that were made on the PR to dmf#12
Merged
pac-work merged 15 commits intopac-work:rust-bindingsfrom Oct 8, 2025
Merged
Address some of the comments that were made on the PR to dmf#12pac-work merged 15 commits intopac-work:rust-bindingsfrom
pac-work merged 15 commits intopac-work:rust-bindingsfrom
Conversation
cargo audit was being installed twice Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
cargo audit complained about RUSTSEC-2025-0055 Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Asked on Slack for guidance regarding which licenses should be accepted. Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Owner
|
Some of the commits seems to not be signed off, @pedro-alves-ferreira . |
The api is now returned as an Arc, which can be cloned. Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
pedro-alves-ferreira
force-pushed
the
pf/pr-comments
branch
from
c34db92 to
44c6dc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.