ci: add workflow stages for rust bindings#11
Merged
pac-work merged 10 commits intopac-work:rust-bindingsfrom Oct 8, 2025
Merged
ci: add workflow stages for rust bindings#11pac-work merged 10 commits intopac-work:rust-bindingsfrom
pac-work merged 10 commits intopac-work:rust-bindingsfrom
Conversation
cargo audit was being installed twice Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
f2f543b to
bda6e64
Compare
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
cargo audit complained about RUSTSEC-2025-0055 Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Asked on Slack for guidance regarding which licenses should be accepted. Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
Signed-off-by: Pedro Ferreira <pedro@bisect.pt>
bda6e64 to
5697524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new steps to validate and build the Rust bindings. It also corrects some minor issues, so that the validations pass.
The
rust.ymlfile that @cwtchan had created was removed and mostly replaced by some of these additional steps.This is not ideal and I would like to have separate files for C++ and Rust, but it is not trivial to get the prerequisites right without a significant amount of duplication in the workflows.
Any suggestions would be appreciated.
The test report that is generated by cargo nextest is not merged with the one from the C++ tests. I will do that in a subsequent PR.