Conversation
I manually did the update with out any software telling me where errors were. So if you run php code sniffer there may be more warnings but I fixed the spaces and curly braces.
|
You want to change from PSR-0 to PSR-4 autoloaders (#263), but don't want to follow PSR-1 and PSR-2 code styling? What's the advantage of another non-standard code styling? Your proposal is neither better nor worse oyejorges code styling, except for the fact that this is oyejorges project and he's the only person entitled to choose the code styling he personally prefers 😉 |
|
Hi I carnt find anything on psr-1 or psr-2 I can only see psr-4 and psr-0 in google search results. |
|
http://www.php-fig.org/psr/psr-1/ Code styling is a completely subjective thing, before doing this you should wait for @oyejorge's feedback if he actually wants this. |
|
Well the closest thing to psr-0 is psr-4 Please see http://www.php-fig.org/psr/psr-0/ which recommends using psr-4. |
|
Oh. So psr-1 and psr-2 are code styling didn't know that sorry. I am not sure what to do to follow that. Is there any composer packages that follow there coding standards. |
|
Exactly. Just read the PSR-1 and PSR-2 docs, they already contain examples. As said, before doing this you should wait for @oyejorge's feedback. |
I manually did the update with out any software telling me where errors were.
So if you run php code sniffer there may be more warnings but I fixed the spaces and curly braces.