return success from mc_multicst(9e) #905
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in IPv6 e2e testing with omicron probes.
Wiring up
mc_multicst(9e)is required for omicron probes setting up addresses directly on opte devices. TheNeighborAdvertisementHairpinActionexpects multicast macs. But withoutmc_multicst(9e)plumbed, multicast macs will fall back to broadcast macs, theHairpinActionpredicates will fail and ndp will go nowhere in the probe zone.My read of
mc_multicst(9e)is that it is both an opportunity for a driver to set up multicast filtering on a device, and to signal to the kernel that multicast addressing is supported for data links on said device. Since we're not doing any hardware-based multicast filtering at the moment, I think it's sufficient to simply signal multicast L2 address support to the kernel.When we return
ENOTSUPfor themc_multicstentry point, we see the following in the kernel logs when multicast addresses are assigned to OPTE data links.Which results in NDP traffic using broadcast macs instead of multicast macs.
I've taken this patch for a spin in a4x2. Everything comes up. NDP traffic flows over OPTE devices use multicast addressing and address setup works as expected.